On 26.04.2010, at 15:35, Levente Uzonyi wrote:
> 
> On Mon, 26 Apr 2010, Bert Freudenberg wrote:
> 
>> On 26.04.2010, at 13:04, Levente Uzonyi wrote:
>>> 
>>> On Mon, 26 Apr 2010, commits at source.squeak.org wrote:
>>> 
>>>> Alexander Lazarević uploaded a new version of Morphic to project The Trunk:
>>>> http://source.squeak.org/trunk/Morphic-laza.430.mcz
>>>> 
>>>> ==================== Summary ====================
>>>> 
>>>> Name: Morphic-laza.430
>>>> Author: laza
>>>> Time: 26 April 2010, 12:25:16.993 pm
>>>> UUID: 6362395c-21df-0d4a-a187-99a03416c76c
>>>> Ancestors: Morphic-laza.429
>>>> 
>>>> Add Seaside 2.8, 2.8 Examples and 3.0 to the "How to extend the system" workspace
>>>> 
>>>> =============== Diff against Morphic-laza.429 ===============
>>>> 
>>>> Item was changed:
>>>> (excessive method size, no diff calculated)
>>> 
>>> Errr, why isn't there a diff? What's excessive?
>> 
>> MCDiffyTextWriter>>writePatchFrom: src to: dst
>> 	"src and dst are allowed to bi nil to represent a non-existent source or destination state"
>> 
>> 	| source target |
>> 	source := src ifNotNil: [self visitInFork: src] ifNil: [''].
>> 	target := dst ifNotNil: [self visitInFork: dst] ifNil: [''].
>> 	source size + target size > 10000
>> 		ifTrue: [ stream nextPutAll: '(excessive method size, no diff calculated)'; cr ]
>> 		ifFalse: [
>> 			stream nextPutAll: (TextDiffBuilder from: source to: target)
>> 				buildTextPatch ]
>> 
> 
> A limit based on the number of lines would be better IMHO.
> 
> 
> Levente

I guess Lukas put this in to avoid excessive load on the squeaksource server. This test is *really* cheap.

But feel free to send a patch :)

(ideally it would limit the length of the diff that gets mailed out, as well as the time spent on calculating it, all the while preserving the simplicity of the code)

- Bert -