[squeak-dev] autoAccessors broken in 4.1 rc5

Levente Uzonyi leves at elte.hu
Sun Apr 18 20:47:10 UTC 2010


On Sun, 18 Apr 2010, Chris Muller wrote:

> I don't understand how these sorts of fragments get into the image.
> When you look at 3.9, the only senders of autoAccessors are for a
> remove-script apparently to get rid of it.
>
> So my question is:  Given that we are all trying to make the image
> smaller and cleaner, how did this happen?
>
> We know better than to half-introduce a feature or half-remove a
> feature.  What happened here and do we need to consider additional
> quality-control measures to catch these sorts of things?
>
> Here is one example:  Before I version anything in MC, I review the
> "Changes" list, and review every single change, to understand and
> confirm why it was made.  I *assume* that everyone else does this too;
> but then I won't tell you what my mother told me about "assume"..

Probably Eliot's closure changes were developed in a 3.8 image, that's how 
it was reintroduced. I think it's safe to remove this part from Object >> 
#doesNotUnderstand:

(Preferences autoAccessors
 	 and: [self tryToDefineVariableAccess: aMessage]) ifTrue:
 		[^aMessage sentTo: self].


Levente

>
>
>
> 2010/4/16 Stéphane Rollandin <lecteur at zogotounga.net>:
>> hello,
>>
>> Preferences autoAccessor when turned on seems to break badly the Object
>> #doesNotUnderstand logic.
>>
>> try this is the latest image:
>>
>>        Preferences enable: #autoAccessors.
>>        5 annoyWith: 7
>>
>> (beware it will hang the image for good)
>>
>> Stef
>>
>>
>>
>>
>>
>
>


More information about the Squeak-dev mailing list