For more than one year, drag'n'drop from the host system into the VM was broken on Linux/X11 due to a regression introduced via facfd90. primitiveDropRequestFileName would always answer home/Christoph/myfile.txt rather than /home/Christoph/myfile.txt, causing the file to be ignored on the image-side in Squeak. Now I finally found the cause of the bug, it was a simple off-by-one error.

Tested on Linux/Ubuntu with XDG/Nautilus under WSL/VcXsrv. The bug was also reported to occur on native Linux distributions, though.

Notes:

I don't know any system or application that would pass paths in one of the other formats (file:/path or /path). If anyone knows such applications, this would make a nice reprocase. Could you please test this out in your environment?
Related issue: There was also a bug report for DnD on macOS always being one file behind, i.e., nothing appearing in the image on the first drop, the first file appearing on the drop, etc. However, I think this is unrelated to this bug (different platform) and I have also no option to reproduce this unless Apple provides usable visualization support. If anyone is addressing the issue, skimming the history around facfd90 might be a good starting point, anyway.

Mentioning @eliotmiranda as the author of facfd90 and @marceltaeumel FYIO. :-)

You can view, comment on, or merge this pull request online at:

https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/616

Commit Summary

e51c41f DnD/Unix: Fix dropRequestFileName which removed the trailing slash from the path

File Changes

(1 file)

M platforms/unix/plugins/DropPlugin/sqUnixDragDrop.c (20)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.