Hi K, Hi David,

    can you explain this to me?  I don't understand why one wouldn't want to test that the 64-bit Cog image format is valid.  This probably just needs a few more words.  I'm not suggesting that the change is wrong, simply that I don't understand it.

On Wed, Apr 10, 2019 at 2:22 PM <commits@source.squeak.org> wrote:
 
David T. Lewis uploaded a new version of ImageFormat to project VM Maker:
http://source.squeak.org/VMMaker/ImageFormat-kks.35.mcz

==================== Summary ====================

Name: ImageFormat-kks.35
Author: kks
Time: 10 April 2019, 11:21:27.422478 pm
UUID: 67c4b2d3-702b-447e-890c-1ba698a71b4f
Ancestors: ImageFormat-kks.34

Removed tests for 68004, 68021 formats since 68004 is no longer a base version number.

=============== Diff against ImageFormat-kks.34 ===============

Item was changed:
  ----- Method: ImageFormatTest>>testIsValidVersionNumber (in category 'testing') -----
  testIsValidVersionNumber

        self should: [ImageFormat fromInteger: 0] raise: Error.
        self should: [ImageFormat fromInteger: (6502 bitAnd: 16r80000000)] raise: Error.
        self should: [ImageFormat fromInteger: (6502 bitAt: 31 put: 1)] raise: Error.
        self should: [ImageFormat fromInteger: 6500] raise: Error.
        self should: [ImageFormat fromInteger: 6501] raise: Error.
        self should: [ImageFormat fromInteger: 6503] raise: Error. "Cog requires both capabilities"
        self should: [ImageFormat fromInteger: 68001] raise: Error. "Cog requires both capabilities"

        self assert: ImageFormat default isValidVersionNumber.
        self assert: (ImageFormat wordSize: 4 closures: false) isValidVersionNumber.
        self assert: (ImageFormat wordSize: 4 closures: true) isValidVersionNumber.
        self assert: (ImageFormat wordSize: 8 closures: false) isValidVersionNumber.
        self assert: (ImageFormat wordSize: 8 closures: true) isValidVersionNumber.
        self assert: (ImageFormat fromInteger: 6502) isValidVersionNumber.
        self assert: (ImageFormat fromInteger: (6502 bitAt: 31 put: 0)) isValidVersionNumber.
        self assert: (ImageFormat fromInteger: 6521) isValidVersionNumber.
        self assert: (ImageFormat fromInteger:68000) isValidVersionNumber.
        self assert: (ImageFormat fromInteger:68002) isValidVersionNumber.
-       self assert: (ImageFormat fromInteger:68004) isValidVersionNumber.
        self assert: (ImageFormat fromInteger:68003) isValidVersionNumber. "valid but unused, as with 68019"
        self assert: (ImageFormat fromInteger: 68019) isValidVersionNumber.
-       self assert: (ImageFormat fromInteger: 68021) isValidVersionNumber.

  !



--
_,,,^..^,,,_
best, Eliot