Ronie submitted a pull request that fixes the build with cygwin for win32 ( #311 ) and I'm curious if any of my changes here are still applicable. @ronsaldo could you comment on these...

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312

Commit Summary

• Fix function call declarations and return types (x64-msvc2017)
• Fix unresolved external symbol 'alloca' (x64-msvc2017)
• Workaround _controlfp() does not support _MCW_PC or _MCW_IC on x64. Expert review required.
• Add architecture define _M_IX86 to ABI (x86-msvc2017)
• Workaround hang allocating initial memory (x64-msvc2017). Expert review required.
• Better 32bit CMakeLists.txt for SqueakFFIPrims (x86-msvc2017)

File Changes

• M CMakeLists.txt (43)
• M platforms/Cross/plugins/IA32ABI/ia32abicc.c (2)
• M platforms/Cross/plugins/IA32ABI/x64win64abicc.c (3)
• M platforms/Cross/plugins/IA32ABI/xabicc.c (2)
• M platforms/minheadless/common/sqMain.c (1)
• M platforms/minheadless/windows/sqPlatformSpecific-Win32.c (9)
• M platforms/minheadless/windows/sqPlatformSpecific-Win32.h (2)
• M platforms/minheadless/windows/sqWin32Main.c (1)
• M platforms/minheadless/windows/sqWin32SpurAlloc.c (9)

Patch Links:

• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/312.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.