On Tue, Jan 12, 2010 at 7:54 AM, Andreas Raab <andreas.raab@gmx.de> wrote:

Igor Stasenko wrote:
Btw,  about that function. Its using a squeakFileOffsetType, which is
platform specific, and i had hard times
trying to deal with right header inclusion order imposing dependency
of interpreter from platform code, which, IMO should be avoided.
I propose to change it to
typedef  unsigned long long vmFileOffsetType;
and use this type instead.

I'm not sure if MSVC supports long long nowadays. It didn't used to - it used to require __int64 which is why the definition of squeakFileOffsetType is external.

We should just use usqLong.  The platform-specific definition in platforms/Cross/vm/sqVirtualMachine.h can be moved to sqMemoryAccess.h so that usqLong & sqLong are also available once sqInt & usqInt are.


 - Andreas