2015-08-11 2:08 GMT+02:00 Eliot Miranda <eliot.miranda@gmail.com>:

Hi Nicolas,Hum, but then wait, see suspicious code below[snip]

Item was changed:

----- Method: SimpleStackBasedCogit>>genPrimitiveLessThan (in category 'primitive generators') -----

genPrimitiveLessThan

+ ^self

+ genSmallIntegerComparison: JumpLess

+ orDoubleComparison: #JumpFPGreaterOrEqual:and shouldn't it be JumpFPGreater ???No. (a>b) = !(b>=a); (a>b) != !(b>a) if a = b.

Hi Eliot,

it seems that you are mixing the two algorithms, the old one and the new one

it seems that you are mixing the two algorithms, the old one and the new one

(a < b) = ( a >= b) not

is wrong and doesn't work with NaN

is wrong and doesn't work with NaN

it was the old implementation which inverted < into >=

(a < b) = (b > a)

is OK and is what you implemented now by reverting the parameters

is OK and is what you implemented now by reverting the parameters

so < must be inverted in >

look again and test with 2 <= 2.0

cheers

Nicolas