Thank you Levente!


On 2024-03-23 21:10, leves wrote:

Hi David,

RFBSocket >> #waitForSendDoneFor: is present even in RFB-ikp.2, which is from 2004.
I removed it back in 2016 with RFB-klub.15 (see the commit message in history as the version is not in the repository), because Socket's #waitForSendDoneFor: just works. The bugs mentioned in the comment must have been fixed in the 2000s.

Best,
Levente

On 2024. 03. 23. 17:27, lewis@mail.msen.com wrote:
SqueakSource servers use the RFB package in the source.squeak.org/ss repository. The RFBSocket>>waitForSendDoneFor: method was removed in merge (RFB-cmm.20). Was this a mistake in the merge?

RFBSocket>>waitForSendDoneFor: was introduced by Levente in 2012 (RFB-ul.7 probably) and was present in the package until 2021 (RFB-cmm.20). It is documented as follows:

   waitForSendDoneFor: timeout
      "This is a (dual) bug-fix implementation only.  Broken VMs (like the
      Windoze one) confuse the read and write Semaphores (bug #1), and the
      new Socket implementation fails utterly to deal properly with the
      situation (bug #2)."

Thanks,
Dave