do we really need to reset the author initials when one opens the image under a different path? This just stroke me a bit when I was trying to prepare an image that does not ask the user for any initials, but the receiver was still told to enter them again.

Also, note that string comparison is not sufficient for comparing paths. For instance, there are multiple ways under Windows to express the same path (UNC paths, virtual drive letters, ...), or even the WSL path when I open the same image, without moving it, from WSL rather from Windows.

Last but not least, this is a really unexpected side effect and I only found this via a sender search.

Is this really necessary? :-)


Sent from Squeak Inbox Talk

On 2018-04-16T08:31:43+00:00, commits@source.squeak.org wrote:

> Marcel Taeumel uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-mt.1018.mcz
> ==================== Summary ====================
> Name: System-mt.1018
> Author: mt
> Time: 16 April 2018, 10:31:28.239614 am
> UUID: e0350560-a5a5-5a40-b31b-d13f55162021
> Ancestors: System-mt.1017
> #setAuthorInitials: -> #authorInitials:
> =============== Diff against System-mt.1017 ===============
> Item was changed:
> ----- Method: SmalltalkImage>>openSourceFiles (in category 'sources, changes log') -----
> openSourceFiles
>     self imageName = LastImageName ifFalse:
>         ["Reset the author initials to blank when the image gets moved"
>         LastImageName := self imageName.
> +         Utilities authorInitials: ''].
> -         Utilities setAuthorInitials: ''].
>     FileDirectory
>         openSources: self sourcesName
>         andChanges: self changesName
>         forImage: LastImageName.
>     SourceFileArray install!